Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/multi region config): mount file and read config from file #3407

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Oct 29, 2024

Description & motivation

Changes:

  • Helm chart introduces new feature flag workspacesMultiRegionEnabled
  • Helm chart mounts file from secret
  • Helm chart sets environment variable MULTI_REGION_CONFIG_PATH
  • Server reads configuration from json file at the given path.
  • Server validates json content match expected schema

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review October 29, 2024 15:16
fabis94
fabis94 previously approved these changes Oct 30, 2024
@iainsproat iainsproat merged commit 8ea43d7 into main Oct 30, 2024
23 of 25 checks passed
@iainsproat iainsproat deleted the iain/multi-region-config branch October 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants